Skip to content

chore: allow PHP 8.4 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025
Merged

chore: allow PHP 8.4 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82ef765
chore: drop PHP <7.4, move to GitHub Actions
keradus Apr 12, 2025
ac901f8
chore: allow PHP 8.4
keradus Apr 12, 2025
19cfd35
fix php 8.4
keradus Apr 12, 2025
a9a4d3d
fix
keradus Apr 12, 2025
6b26322
Merge branch 'master' into chore2
keradus Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
- php: "8.1"
- php: "8.2"
- php: "8.3"
- php: "8.4"
steps:
- name: Checkout source
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion src/ExecutionException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class ExecutionException extends \RuntimeException
*/
private $result;

public function __construct(CliResult $result, $message = '', $code = 0, \Exception $previous = null)
public function __construct(CliResult $result, $message = '', $code = 0, ?\Exception $previous = null)
{
parent::__construct($message, $code, $previous);

Expand Down
4 changes: 2 additions & 2 deletions src/ScriptExecutor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ final class ScriptExecutor
* @param string[] $scriptParts
* @param ?string[] $scriptInit
*/
public function __construct(array $scriptParts, string $cwd, array $scriptInit = null)
public function __construct(array $scriptParts, string $cwd, ?array $scriptInit = null)
{
$this->scriptParts = $scriptParts;
$this->cwd = $cwd;
Expand All @@ -69,7 +69,7 @@ public function __destruct()
* @param string[] $scriptParts
* @param ?string[] $scriptInit
*/
public static function create(array $scriptParts, string $cwd, array $scriptInit = null): self
public static function create(array $scriptParts, string $cwd, ?array $scriptInit = null): self
{
return new self($scriptParts, $cwd, $scriptInit);
}
Expand Down