Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 21, 2025

No description provided.

@jrfnl jrfnl added this to the 1.0.0 milestone Dec 21, 2025
@jrfnl
Copy link
Member Author

jrfnl commented Dec 21, 2025

@fredden If you have the time, I wouldn't mind if you could look this over...

Copy link
Member

@fredden fredden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The words make sense and it's good to get the intent documented.

For the files required to trigger the various workflows, having an asterisk in the filename doesn't look right. If I were to create a file actually called phpstan.neon* or .yamllint.y*ml (which are a perfectly valid file names in Linux), then my guess is that the respective workflows would not actually trigger. Can we list the real filenames that would trigger the workflow?

@jrfnl
Copy link
Member Author

jrfnl commented Dec 21, 2025

If I were to create a file actually called phpstan.neon* or .yamllint.y*ml (which are a perfectly valid file names in Linux), then my guess is that the respective workflows would not actually trigger.

Actually, they probably would as the config file check is just a glob pattern. Then again, the results may not be as expected as the tooling itself may not pick up on the config file correctly 😁

Can we list the real filenames that would trigger the workflow?

👍🏻 Done.

Copy link
Member

@fredden fredden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the globs in the workflow files to match these new more specific definitions of matching files?

Includes updating the documentation about this in the README.
@jrfnl jrfnl force-pushed the feature/readme-write-up-functionality branch from 32b9944 to fdacf63 Compare December 22, 2025 11:27
@jrfnl jrfnl merged commit 9d51cbe into main Dec 22, 2025
10 checks passed
@jrfnl jrfnl deleted the feature/readme-write-up-functionality branch December 22, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants