Skip to content

Composer: update minimum PHPCS version to 3.13.0 + add three new sniffs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025
Merged

Composer: update minimum PHPCS version to 3.13.0 + add three new sniffs #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions PHPCSDev/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@
<!-- No spacing on the inside of arbitrary parentheses. -->
<rule ref="Generic.WhiteSpace.ArbitraryParenthesesSpacing"/>

<!-- No spacing inside heredoc/nowdocs identifiers. -->
<rule ref="Generic.WhiteSpace.HereNowdocIdentifierSpacing"/>

<!-- Align the equal operator in assignment blocks. -->
<rule ref="Generic.Formatting.MultipleStatementAlignment">
<properties>
Expand Down Expand Up @@ -225,6 +228,9 @@
<!-- Efficiency: don't unnecessarily use double quotes. -->
<rule ref="Squiz.Strings.DoubleQuoteUsage.NotRequired"/>

<!-- Efficiency: don't unnecessarily use heredocs. -->
<rule ref="Generic.Strings.UnnecessaryHeredoc"/>

<!-- Error prevention: warns when an inner loop uses the same incrementor as the outer loop. -->
<rule ref="Generic.CodeAnalysis.JumbledIncrementer"/>

Expand All @@ -233,6 +239,9 @@
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition"/>
</rule>

<!-- Error prevention: use parentheses when mixing boolean operators. -->
<rule ref="Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence"/>

<!-- Clean up: remove redundant code. -->
<rule ref="Squiz.PHP.NonExecutableCode">
<!-- Allow for return statement in otherwise empty function. -->
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ PHPCSDev ruleset for sniff repos

Once this project is installed, you will see a new `PHPCSDev` ruleset in the list of installed standards when you run `phpcs -i`.

**Important: This ruleset currently requires PHP_CodeSniffer >= `3.6.2+`.**
**Important: This ruleset currently requires PHP_CodeSniffer >= `3.13.0+`.**

> As sniffs developers will mostly work with the latest version of PHP_CodeSniffer, this shouldn't cause any problems.
>
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"require" : {
"php" : ">=5.4",
"squizlabs/php_codesniffer" : "^3.6.2",
"squizlabs/php_codesniffer" : "^3.13.0",
"phpcompatibility/php-compatibility" : "^9.0.0 || ^10.0.0",
"dealerdirect/phpcodesniffer-composer-installer" : "^0.4.1 || ^0.5 || ^0.6.2 || ^0.7 || ^1.0"
},
Expand Down