Skip to content

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 17, 2025

Description

In the original PR (#6), a Personal Access Token (PAT) was used, but that resulted in the comment being left as if coming from my account, which is misleading, which is why the repo_token was initially switched back to secrets.GITHUB_TOKEN, with a reminder that a test would need to be done with a PR coming from a fork to verify that the auto-comment would still work.

As the first PR from a fork has now come in (#38), it has become clear that the auto-comment does not work with the default GitHub token, so this commit switches the repo_token back to the Personal Access Token and updates the message to make it clear I did not leave the comment.

We'll still have to test (again) whether using the PAT works for PRs coming from forks. If not, we'll have to revisit this workflow step.

@jrfnl
Copy link
Member Author

jrfnl commented Jul 17, 2025

=== This is an auto-generated comment ===

Thank you for your PR.
A dry-run has been executed on your PR, executing all markdown pre-processing for the wiki files.

Please review the resulting final markdown files via the created artifact.
This is especially important when adding new pages or updating auto-generated output blocks.

N.B.: the above link will automatically be updated when this PR is updated.

In the original PR (#6), a Personal Access Token (PAT) was used, but that resulted in the comment being left as if coming from my account, which is misleading, which is why the `repo_token` was initially switched back to `secrets.GITHUB_TOKEN`, with a reminder that a test would need to be done with a PR coming from a fork to verify that the auto-comment would still work.

As the first PR from a fork has now come in (#38), it has become clear that the auto-comment does not work with the default GitHub token, so this commit switches the `repo_token` back to the Personal Access Token and updates the message to make it clear I did not leave the comment.

We'll still have to test (again) whether using the PAT works for PRs coming from forks. If not, we'll have to revisit this workflow step.
@jrfnl jrfnl force-pushed the feature/ghactions-publish-wiki-use-pat-for-comment-on-pr branch from 9d8a8d1 to 520e0ba Compare July 17, 2025 21:11
@jrfnl jrfnl merged commit c923cac into main Jul 17, 2025
14 checks passed
@jrfnl jrfnl deleted the feature/ghactions-publish-wiki-use-pat-for-comment-on-pr branch July 17, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant