Skip to content

Commit 451a701

Browse files
rodrigoprimojrfnl
authored andcommitted
Add links to all issues in the 3.3.2, 3.3.1, 3.3.0 and 2.9.2 sections of the changelog
This commit also fixes a typo in one of the changelogs.
1 parent 99f4260 commit 451a701

File tree

1 file changed

+96
-48
lines changed

1 file changed

+96
-48
lines changed

CHANGELOG.md

Lines changed: 96 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1859,11 +1859,15 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
18591859
- Thanks to [Nick Wilde][@NickDickinsonWilde] for the patch
18601860

18611861
### Fixed
1862-
- Fixed bug #1496 : Squiz.Strings.DoubleQuoteUsage not unescaping dollar sign when fixing
1862+
- Fixed bug [#1496] : Squiz.Strings.DoubleQuoteUsage not unescaping dollar sign when fixing
18631863
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1864-
- Fixed bug #1549 : Squiz.PHP.EmbeddedPhp fixer conflict with // comment before PHP close tag
1864+
- Fixed bug [#1549] : Squiz.PHP.EmbeddedPhp fixer conflict with // comment before PHP close tag
18651865
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1866-
- Fixed bug #1890 : Incorrect Squiz.WhiteSpace.ControlStructureSpacing.NoLineAfterClose error between catch and finally statements
1866+
- Fixed bug [#1890] : Incorrect Squiz.WhiteSpace.ControlStructureSpacing.NoLineAfterClose error between catch and finally statements
1867+
1868+
[#1496]: https://github.com/squizlabs/PHP_CodeSniffer/pull/1496
1869+
[#1549]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1549
1870+
[#1890]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1890
18671871

18681872
## [3.3.2] - 2018-09-24
18691873
### Changed
@@ -1887,20 +1891,31 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
18871891
### Fixed
18881892
- Fixed a problem where referencing a relative file path in a ruleset XML file could add unnecessary sniff exclusions
18891893
- This didn't actually exclude anything, but caused verbose output to list strange exclusion rules
1890-
- Fixed bug #2110 : Squiz.WhiteSpace.FunctionSpacing is removing indents from the start of functions when fixing
1894+
- Fixed bug [#2110] : Squiz.WhiteSpace.FunctionSpacing is removing indents from the start of functions when fixing
18911895
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1892-
- Fixed bug #2115 : Squiz.Commenting.VariableComment not checking var types when the @var line contains a comment
1893-
- Fixed bug #2120 : Tokenizer fails to match T_INLINE_ELSE when used after function call containing closure
1894-
- Fixed bug #2121 : Squiz.PHP.DisallowMultipleAssignments false positive in while loop conditions
1896+
- Fixed bug [#2115] : Squiz.Commenting.VariableComment not checking var types when the @var line contains a comment
1897+
- Fixed bug [#2120] : Tokenizer fails to match T_INLINE_ELSE when used after function call containing closure
1898+
- Fixed bug [#2121] : Squiz.PHP.DisallowMultipleAssignments false positive in while loop conditions
18951899
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1896-
- Fixed bug #2127 : File::findExtendedClassName() doesn't support nested classes
1900+
- Fixed bug [#2127] : File::findExtendedClassName() doesn't support nested classes
18971901
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1898-
- Fixed bug #2138 : Tokenizer detects wrong token for php ::class feature with spaces
1899-
- Fixed bug #2143 : PSR2.Namespaces.UseDeclaration does not properly fix "use function" and "use const" statements
1902+
- Fixed bug [#2138] : Tokenizer detects wrong token for php ::class feature with spaces
1903+
- Fixed bug [#2143] : PSR2.Namespaces.UseDeclaration does not properly fix "use function" and "use const" statements
19001904
- Thanks to [Chris Wilkinson][@thewilkybarkid] for the patch
1901-
- Fixed bug #2144 : Squiz.Arrays.ArrayDeclaration does incorrect align calculation in array with cyrillic keys
1902-
- Fixed bug #2146 : Zend.Files.ClosingTag removes closing tag from end of file without inserting a semicolon
1903-
- Fixed bug #2151 : XML schema not updated with the new array property syntax
1905+
- Fixed bug [#2144] : Squiz.Arrays.ArrayDeclaration does incorrect align calculation in array with cyrillic keys
1906+
- Fixed bug [#2146] : Zend.Files.ClosingTag removes closing tag from end of file without inserting a semicolon
1907+
- Fixed bug [#2151] : XML schema not updated with the new array property syntax
1908+
1909+
[#2110]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2110
1910+
[#2115]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2115
1911+
[#2120]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2120
1912+
[#2121]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2121
1913+
[#2127]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2127
1914+
[#2138]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2138
1915+
[#2143]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2143
1916+
[#2144]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2144
1917+
[#2146]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2146
1918+
[#2151]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2151
19041919

19051920
## [3.3.1] - 2018-07-27
19061921
### Removed
@@ -1955,15 +1970,24 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
19551970
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
19561971

19571972
### Fixed
1958-
- Fixed bug #2029 : Squiz.Scope.MemberVarScope throws fatal error when a property is found in an interface
1959-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1960-
- Fixed bug #2047 : PSR12.Classes.ClassInstantiation false positive when instantiating class from array index
1961-
- Fixed bug #2048 : GenericFormatting.MultipleStatementAlignment false positive when assigning values inside an array
1962-
- Fixed bug #2053 : PSR12.Classes.ClassInstantiation incorrectly fix when using member vars and some variable formats
1963-
- Fixed bug #2065 : Generic.ControlStructures.InlineControlStructure fixing fails when inline control structure contains closure
1964-
- Fixed bug #2072 : Squiz.Arrays.ArrayDeclaration throws NoComma error when array value is a shorthand IF statement
1965-
- Fixed bug #2082 : File with "defined() or define()" syntax triggers PSR1.Files.SideEffects.FoundWithSymbols
1966-
- Fixed bug #2095 : PSR2.Namespaces.NamespaceDeclaration does not handle namespaces defined over multiple lines
1973+
- Fixed bug [#2029] : Squiz.Scope.MemberVarScope throws fatal error when a property is found in an interface
1974+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1975+
- Fixed bug [#2047] : PSR12.Classes.ClassInstantiation false positive when instantiating class from array index
1976+
- Fixed bug [#2048] : GenericFormatting.MultipleStatementAlignment false positive when assigning values inside an array
1977+
- Fixed bug [#2053] : PSR12.Classes.ClassInstantiation incorrectly fix when using member vars and some variable formats
1978+
- Fixed bug [#2065] : Generic.ControlStructures.InlineControlStructure fixing fails when inline control structure contains closure
1979+
- Fixed bug [#2072] : Squiz.Arrays.ArrayDeclaration throws NoComma error when array value is a shorthand IF statement
1980+
- Fixed bug [#2082] : File with "defined() or define()" syntax triggers PSR1.Files.SideEffects.FoundWithSymbols
1981+
- Fixed bug [#2095] : PSR2.Namespaces.NamespaceDeclaration does not handle namespaces defined over multiple lines
1982+
1983+
[#2029]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2029
1984+
[#2047]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2047
1985+
[#2048]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2048
1986+
[#2053]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2053
1987+
[#2065]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2065
1988+
[#2072]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2072
1989+
[#2082]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2082
1990+
[#2095]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2095
19671991

19681992
## [3.3.0] - 2018-06-07
19691993
### Deprecated
@@ -2137,42 +2161,66 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
21372161
- If not set, the sniff will use whatever value is set for the existing 'spacing' property
21382162

21392163
### Fixed
2140-
- Fixed bug #1863 : File::findEndOfStatement() not working when passed a scope opener
2141-
- Fixed bug #1876 : PSR2.Namespaces.UseDeclaration not giving error for use statements before the namespace declaration
2164+
- Fixed bug [#1863] : File::findEndOfStatement() not working when passed a scope opener
2165+
- Fixed bug [#1876] : PSR2.Namespaces.UseDeclaration not giving error for use statements before the namespace declaration
21422166
- Adds a new PSR2.Namespaces.UseDeclaration.UseBeforeNamespace error message
2143-
- Fixed bug #1881 : Generic.Arrays.ArrayIndent is indenting sub-arrays incorrectly when comma not used after the last value
2144-
- Fixed bug #1882 : Conditional with missing braces confused by indirect variables
2145-
- Fixed bug #1915 : JS tokenizer fails to tokenize regular expression proceeded by boolean not operator
2146-
- Fixed bug #1920 : Directory exclude pattern improperly excludes files with names that start the same
2167+
- Fixed bug [#1881] : Generic.Arrays.ArrayIndent is indenting sub-arrays incorrectly when comma not used after the last value
2168+
- Fixed bug [#1882] : Conditional with missing braces confused by indirect variables
2169+
- Fixed bug [#1915] : JS tokenizer fails to tokenize regular expression proceeded by boolean not operator
2170+
- Fixed bug [#1920] : Directory exclude pattern improperly excludes files with names that start the same
21472171
- Thanks to [Jeff Puckett][@jpuck] for the patch
2148-
- Fixed bug #1922 : Equal sign alignment check broken when list syntax used before assignment operator
2149-
- Fixed bug #1925 : Generic.Formatting.MultipleStatementAlignment skipping assignments within closures
2150-
- Fixed bug #1931 : Generic opening brace placement sniffs do not correctly support function return types
2151-
- Fixed bug #1932 : Generic.ControlStructures.InlineControlStructure fixer moves new PHPCS annotations
2152-
- Fixed bug #1938 : Generic opening brace placement sniffs incorrectly move PHPCS annotations
2172+
- Fixed bug [#1922] : Equal sign alignment check broken when list syntax used before assignment operator
2173+
- Fixed bug [#1925] : Generic.Formatting.MultipleStatementAlignment skipping assignments within closures
2174+
- Fixed bug [#1931] : Generic opening brace placement sniffs do not correctly support function return types
2175+
- Fixed bug [#1932] : Generic.ControlStructures.InlineControlStructure fixer moves new PHPCS annotations
2176+
- Fixed bug [#1938] : Generic opening brace placement sniffs incorrectly move PHPCS annotations
21532177
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2154-
- Fixed bug #1939 : phpcs:set annotations do not cause the line they are on to be ignored
2178+
- Fixed bug [#1939] : phpcs:set annotations do not cause the line they are on to be ignored
21552179
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2156-
- Fixed bug #1949 : Squiz.PHP.DisallowMultipleAssignments false positive when using namespaces with static assignments
2157-
- Fixed bug #1959 : SquizMultiLineFunctionDeclaration error when param has trailing comment
2180+
- Fixed bug [#1949] : Squiz.PHP.DisallowMultipleAssignments false positive when using namespaces with static assignments
2181+
- Fixed bug [#1959] : SquizMultiLineFunctionDeclaration error when param has trailing comment
21582182
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2159-
- Fixed bug #1963 : Squiz.Scope.MemberVarScope does not work for multiline member declaration
2183+
- Fixed bug [#1963] : Squiz.Scope.MemberVarScope does not work for multiline member declaration
21602184
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2161-
- Fixed bug #1971 : Short array list syntax not correctly tokenized if short array is the first content in a file
2162-
- Fixed bug #1979 : Tokenizer does not change heredoc to nowdoc token if the start tag contains spaces
2163-
- Fixed bug #1982 : Squiz.Arrays.ArrayDeclaration fixer sometimes puts a comma in front of the last array value
2164-
- Fixed bug #1993 : PSR1/PSR2 not reporting or fixing short open tags
2165-
- Fixed bug #1996 : Custom report paths don't work on case-sensitive filesystems
2166-
- Fixed bug #2006 : Squiz.Functions.FunctionDeclarationArgumentSpacing fixer removes comment between parens when no args
2185+
- Fixed bug [#1971] : Short array list syntax not correctly tokenized if short array is the first content in a file
2186+
- Fixed bug [#1979] : Tokenizer does not change heredoc to nowdoc token if the start tag contains spaces
2187+
- Fixed bug [#1982] : Squiz.Arrays.ArrayDeclaration fixer sometimes puts a comma in front of the last array value
2188+
- Fixed bug [#1993] : PSR1/PSR2 not reporting or fixing short open tags
2189+
- Fixed bug [#1996] : Custom report paths don't work on case-sensitive filesystems
2190+
- Fixed bug [#2006] : Squiz.Functions.FunctionDeclarationArgumentSpacing fixer removes comment between parens when no args
21672191
- The SpacingAfterOpenHint error message has been removed
2168-
- It is replaced by the the existing SpacingAfterOpen message
2192+
- It is replaced by the existing SpacingAfterOpen message
21692193
- The error message format for the SpacingAfterOpen and SpacingBeforeClose messages has been changed
21702194
- These used to contain 3 pieces of data, but now only contain 2
21712195
- If you have customised the error messages of this sniff, please review your ruleset after upgrading
2172-
- Fixed bug #2018 : Generic.Formatting.MultipleStatementAlignment does see PHP close tag as end of statement block
2173-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2174-
- Fixed bug #2027 : PEAR.NamingConventions.ValidFunctionName error when function name includes double underscore
2175-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2196+
- Fixed bug [#2018] : Generic.Formatting.MultipleStatementAlignment does see PHP close tag as end of statement block
2197+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2198+
- Fixed bug [#2027] : PEAR.NamingConventions.ValidFunctionName error when function name includes double underscore
2199+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
2200+
2201+
[#1863]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1863
2202+
[#1876]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1876
2203+
[#1881]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1881
2204+
[#1882]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1882
2205+
[#1915]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1915
2206+
[#1920]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1920
2207+
[#1922]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1922
2208+
[#1925]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1925
2209+
[#1931]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1931
2210+
[#1932]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1932
2211+
[#1938]: https://github.com/squizlabs/PHP_CodeSniffer/pull/1938
2212+
[#1939]: https://github.com/squizlabs/PHP_CodeSniffer/pull/1939
2213+
[#1949]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1949
2214+
[#1959]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1959
2215+
[#1963]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1963
2216+
[#1971]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1971
2217+
[#1979]: https://github.com/squizlabs/PHP_CodeSniffer/pull/1979
2218+
[#1982]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1982
2219+
[#1993]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1993
2220+
[#1996]: https://github.com/squizlabs/PHP_CodeSniffer/issues/1996
2221+
[#2006]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2006
2222+
[#2018]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2018
2223+
[#2027]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2027
21762224

21772225
## [3.2.3] - 2018-02-21
21782226
### Changed

0 commit comments

Comments
 (0)