Generators/HTML::getFormattedFooter(): minor simplification

Use a single call to `sprintf()` instead of lots of string concatenation.

Author: jrfnl

src/Generators/HTML.php

@@ -245,16 +245,17 @@ protected function getFormattedFooter()
         // Turn off errors so we don't get timezone warnings if people
         // don't have their timezone set.
         $errorLevel = error_reporting(0);
-        $output     = '  <div class="tag-line">';
-        $output    .= 'Documentation generated on '.date('r');
-        $output    .= ' by <a href="https://github.com/PHPCSStandards/PHP_CodeSniffer">PHP_CodeSniffer '.Config::VERSION.'</a>';
-        $output    .= '</div>'.PHP_EOL;
+        $output     = sprintf(
+            '  <div class="tag-line">Documentation generated on %s by <a href="https://github.com/PHPCSStandards/PHP_CodeSniffer">PHP_CodeSniffer %s</a></div>
+ </body>
+</html>',
+            date('r'),
+            Config::VERSION
+        );
         error_reporting($errorLevel);
 
-        $output .= ' </body>'.PHP_EOL;
-        $output .= '</html>'.PHP_EOL;
-
-        return $output;
+        // Use the correct line endings based on the OS.
+        return str_replace("\n", PHP_EOL, $output).PHP_EOL;
 
     }//end getFormattedFooter()
 

tests/Core/Generators/Fixtures/HTMLDouble.php

@@ -20,14 +20,12 @@ class HTMLDouble extends HTML
      */
     protected function getFormattedFooter()
     {
-        $output     = '  <div class="tag-line">';
-        $output    .= 'Documentation generated on #REDACTED#';
-        $output    .= ' by <a href="https://github.com/PHPCSStandards/PHP_CodeSniffer">PHP_CodeSniffer #VERSION#</a>';
-        $output    .= '</div>'.PHP_EOL;
-        $output .= ' </body>'.PHP_EOL;
-        $output .= '</html>'.PHP_EOL;
+        $output ='  <div class="tag-line">Documentation generated on #REDACTED# by <a href="https://github.com/PHPCSStandards/PHP_CodeSniffer">PHP_CodeSniffer #VERSION#</a></div>
+ </body>
+</html>';
 
-        return $output;
+        // Use the correct line endings based on the OS.
+        return str_replace("\n", PHP_EOL, $output).PHP_EOL;
     }
 
     /**