Tokenizer/PHP: goto label check - minor tweak #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the check for a double colon works correctly when there is no whitespace/comments between the tokens, there could still be unnecessary token walking if there was (whitespace/comments). Fixed now. Includes some extra tests (which would previously already pass, but now more efficiently). Follow up to squizlabs/PHP_CodeSniffer 155
rodrigoprimo
approved these changes
Apr 17, 2025
jrfnl
deleted the
phpcs-4.0/feature/185-tokenizer-php-goto-label-minor-tweak
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the check for a double colon works correctly when there is no whitespace/comments between the tokens, there could still be unnecessary token walking if there was (whitespace/comments).
Fixed now.
Includes some extra tests (which would previously already pass, but now more efficiently).
Follow up to squizlabs/PHP_CodeSniffer#155
Suggested changelog entry
N/A