Tokenizer/Comment: add docblock open + close ptr to all docblock tokens #1019
+44
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only tokens of type `T_DOC_COMMENT_OPEN_TAG ` would receive a `comment_closer` index and tokens of type `T_DOC_COMMENT_CLOSE_TAG ` would receive a `comment_opener` index (asymmetrically). This commit changes this to set both the `comment_opener` as well as the `comment_closer` indexes on all docblock tokens. This should allow for more flexibility for sniffs examining docblocks. Includes updated tests to safeguard this change. Fixes 484
rodrigoprimo
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, only tokens of type
T_DOC_COMMENT_OPEN_TAGwould receive acomment_closerindex and tokens of typeT_DOC_COMMENT_CLOSE_TAGwould receive acomment_openerindex (asymmetrically).This commit changes this to set both the
comment_openeras well as thecomment_closerindexes on all docblock tokens. This should allow for more flexibility for sniffs examining docblocks.Includes updated tests to safeguard this change.
Suggested changelog entry
Changed:
All
T_DOC_COMMENT_*tokens will now have thecomment_openerandcomment_closerindexes set.Related issues/external references
Fixes #484