Filter: files without extension are no longer ignored if the path is passed in directly #1022
+97
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
approved these changes
Apr 17, 2025
jrfnl
force-pushed
the
phpcs-4.0/feature/sq-2916-filter-allow-explicit-file-without-extension
branch
from
941e96b to
3b85aa9
Compare
…passed in directly Fixes squizlabs/PHP_CodeSniffer 2916 Co-authored-by: jrfnl <[email protected]>
jrfnl
force-pushed
the
phpcs-4.0/feature/sq-2916-filter-allow-explicit-file-without-extension
branch
from
3b85aa9 to
3023b6c
Compare
|
I've ended up making two minor tweaks to the test documentation. Merging once the build passes. |
jrfnl
deleted the
phpcs-4.0/feature/sq-2916-filter-allow-explicit-file-without-extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry
Added:
Files without extension can now be scanned if the path is passed in directly.
- Previously, files without extension would always be ignored.
- Now, files with no extension are checked if explicitly passed on the command line or specified in a ruleset.
- Files without extension will still be ignored when scanning directories recursively.
Related issues/external references
Fixes squizlabs/PHP_CodeSniffer#2916