Skip to content

Modernize: use list in foreach #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Modernize: use list in foreach #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Util/MessageCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ public function display($order=self::ORDERBY_SEVERITY)
*/
private function prefixAll(array $messages)
{
foreach ($messages as $i => $details) {
$messages[$i]['message'] = $this->prefix($details['message'], $details['type']);
foreach ($messages as $i => list('message' => $message, 'type' => $type)) {
$messages[$i]['message'] = $this->prefix($message, $type);
}

return $messages;
Expand Down Expand Up @@ -242,22 +242,22 @@ private function sortBySeverity(array $messages)
$notices = [];
$deprecations = [];

foreach ($messages as $details) {
switch ($details['type']) {
foreach ($messages as list('message' => $message, 'type' => $type)) {
switch ($type) {
case self::ERROR:
$errors[] = $details['message'];
$errors[] = $message;
break;

case self::WARNING:
$warnings[] = $details['message'];
$warnings[] = $message;
break;

case self::DEPRECATED:
$deprecations[] = $details['message'];
$deprecations[] = $message;
break;

default:
$notices[] = $details['message'];
$notices[] = $message;
break;
}
}
Expand Down