Config: remove some more output buffering #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
approved these changes
Apr 28, 2025
I don't see why output buffering is needed here. The `DeepExitException` accepts/allows an empty string as the "message", so there is no reason to collect the screen output via buffering first, only to echo it out again as soon as the exception is caught (by the `Runner`) class.
jrfnl
force-pushed
the
phpcs-4.0/feature/remove-more-output-buffering-from-config-2
branch
from
a101d0c to
806b343
Compare
|
Rebased without changes. Merging once the build has passed. |
jrfnl
deleted the
phpcs-4.0/feature/remove-more-output-buffering-from-config-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't see why output buffering is needed here.
The
DeepExitExceptionaccepts/allows an empty string as the "message", so there is no reason to collect the screen output via buffering first, only to echo it out again as soon as the exception is caught (by theRunnerclass).Suggested changelog entry
N/A