StandardRulesetsQATest: fix the test #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the change to the `StatusWriter` for writing error output to `STDERR`, this test was no longer working correctly as the output bufffering was only catching output send to `STDOUT`, which means the protection this test was supposed to give was no undone. Fixed now. And this includes removing yet some more output buffering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the change to the
StatusWriterfor writing error output toSTDERR, this test was no longer working correctly as the output bufffering was only catching output send toSTDOUT, which means the protection this test was supposed to give was no undone.Fixed now. And this includes removing yet some more output buffering.
Suggested changelog entry
N/A