Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,15 @@ public function process(File $phpcsFile, $stackPtr)
}//end if
} else {
$error = strtoupper($type).' statements must be defined using a colon';
$phpcsFile->addError($error, $nextCase, 'WrongOpener'.$type);
if ($tokens[$opener]['code'] === T_SEMICOLON) {
$fix = $phpcsFile->addFixableError($error, $nextCase, 'WrongOpener'.$type);
if ($fix === true) {
$phpcsFile->fixer->replaceToken($opener, ':');
}
} else {
// Probably a case/default statement with colon + curly braces.
$phpcsFile->addError($error, $nextCase, 'WrongOpener'.$type);
}
}//end if

// We only want cases from here on in.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -609,3 +609,16 @@ switch ( $a ) {

jumpOut:
doSomething();

// Fixable semicolon as case/default scope opener.
switch ($value) {
case 'foo';
case 'bar' /*comment*/ ;
case 'baz' ;
echo 'foo, bar, or baz';
break;
default;
echo 'Other';
default ;
echo 'Other';
}
Original file line number Diff line number Diff line change
Expand Up @@ -604,3 +604,16 @@ switch ( $a ) {

jumpOut:
doSomething();

// Fixable semicolon as case/default scope opener.
switch ($value) {
case 'foo':
case 'bar' /*comment*/:
case 'baz':
echo 'foo, bar, or baz';
break;
default:
echo 'Other';
default:
echo 'Other';
}
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ public function getErrorList()
541 => 1,
558 => 1,
575 => 1,
615 => 1,
616 => 1,
617 => 1,
620 => 1,
622 => 1,
];

}//end getErrorList()
Expand Down