Skip to content

PHP 8.5 | Update tests involving the disable_classes ini setting #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

PHP 8.5 | Update tests involving the disable_classes ini setting #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Core/Config/IniSetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ public static function dataIniValueCannotBeUpdatedAtRuntime()
return [
// Using Core directives available PHP cross-version to prevent the tests failing
// on an unavailable directive or due to an extension not being available.
'php.ini only option: disable_classes' => [
'option' => 'disable_classes',
'newValue' => 'DateTime,DOMComment',
'alternativeValue' => 'DOMComment,DateTime',
'php.ini only option: expose_php' => [
'option' => 'expose_php',
'newValue' => '0',
'alternativeValue' => '1',
],
'INI_PERDIR option: short_open_tag (bool)' => [
'option' => 'short_open_tag',
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/Ruleset/IniSetFailIniOnlyTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="IniSetTest" xsi:noNamespaceSchemaLocation="phpcs.xsd">
<description>Ruleset to test ini values which can not be changed at runtime will be reported as such when set from the ruleset.</description>

<ini name="disable_classes" value="DateTime,DOMComment"/>
<ini name="expose_php" value="0"/>

<!-- Prevent a "no sniff were registered" error. -->
<rule ref="Generic.PHP.BacktickOperator"/>
Expand Down
6 changes: 3 additions & 3 deletions tests/Core/Ruleset/ProcessRulesetIniSetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,10 @@ public static function dataIniValueCannotBeUpdatedAtRuntime()
return [
// Using Core directives available PHP cross-version to prevent the tests failing
// on an unavailable directive or due to an extension not being available.
'php.ini only option: disable_classes' => [
'php.ini only option: expose_php' => [
'standard' => __DIR__.'/IniSetFailIniOnlyTest.xml',
'option' => 'disable_classes',
'expected' => 'DateTime,DOMComment',
'option' => 'expose_php',
'expected' => '0',
],
'INI_PERDIR option: short_open_tag' => [
'standard' => __DIR__.'/IniSetFailIniPerDirTest.xml',
Expand Down
Loading