AbstractMethodTestCase/AbstractTokenizerTestCase: use LocalFile instead of DummyFile #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of DummyFile Should work just the same and just as well. Historical context: looks like the use of `DummyFile` is a left over from a time long, long ago, when the "test case code" was included in the same file as the unit test class. This was changed in 2016 for PHPCS 2.x via PR squizlabs/PHP_CodeSniffer 1193, but then the merge up into PHPCS 3.x (which introduced `DummyFile`) did not change the object instantiation.
jrfnl
deleted the
phpcs-4.0/feature/abstract-testcases-use-localfile-not-dummyfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should work just the same and just as well.
Historical context: looks like the use of
DummyFileis a left over from a time long, long ago, when the "test case code" was included in the same file as the unit test class. This was changed in 2016 for PHPCS 2.x via PR squizlabs/PHP_CodeSniffer#1193, but then the merge up into PHPCS 3.x (which introducedDummyFile) did not change the object instantiation.Suggested changelog entry
N/A