CS: normalize code style rules [5] #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes removing the rule from the PHPCS native ruleset and adding another one to enforce the opposite, i.e. forbid end comments.
These made sense for readability with the noisy `//end ...` comments, but not without those... they really are not needed. Includes removing the rule from the PHPCS native ruleset and adding another one to enforce the opposite, i.e. no blank line between function body and close curly. Includes updating the comment format used for "required method which we don't use" comments in four sniffs to not run into "Empty line required after block comment" issues.
Includes adjusting the rule from the PHPCS native ruleset to enforce no blank lines at the end of a class (well, no blank lines after the last function in an OO structure).
jrfnl
deleted the
phpcs-4.x/feature/155-normalize-some-code-style-rules-5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CS: remove class/function end comments
Includes removing the rule from the PHPCS native ruleset and adding another one to enforce the opposite, i.e. forbid end comments.
CS: remove blank line at end of functions
These made sense for readability with the noisy
//end ...comments, but not without those... they really are not needed.Includes removing the rule from the PHPCS native ruleset and adding another one to enforce the opposite, i.e. no blank line between function body and close curly.
Includes updating the comment format used for "required method which we don't use" comments in four sniffs to not run into "Empty line required after block comment" issues.
CS: remove blank lines at end of classes
Includes adjusting the rule from the PHPCS native ruleset to enforce no blank lines at the end of a class (well, no blank lines after the last function in an OO structure).
Suggested changelog entry
N/A
Related issues/external references
Part of a series of PRs to address #155