Skip to content

Conversation

0zd0
Copy link

@0zd0 0zd0 commented Oct 4, 2025

Description

Compatibility with PHP-Parser

Related issues/external references

Fixes #1286

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.
  • I have opened a sister-PR in the documentation repository to update the Wiki.

@jrfnl
Copy link
Member

jrfnl commented Oct 4, 2025

@0zd0 Please read my reply to the issue you opened: #1286 (comment)

@jrfnl jrfnl removed the Type: bug label Oct 4, 2025
@jrfnl
Copy link
Member

jrfnl commented Oct 4, 2025

Also: not a bug, but an artificial issue caused by PHP Parser.

@jrfnl
Copy link
Member

jrfnl commented Oct 4, 2025

Tempted to close this as:

  1. It breaks things as I already pointed out in my previous comment, it would.
  2. Pulled against the wrong branch.
  3. Invalid token numbers.
  4. Tests not passing.

@0zd0
Copy link
Author

0zd0 commented Oct 4, 2025

Okay, I'll use my fork. As I see it, they stifle any initiative here.

@0zd0 0zd0 closed this Oct 4, 2025
@jrfnl
Copy link
Member

jrfnl commented Oct 4, 2025

As I see it, they stifle any initiative here.

Que ? I pointed out what was needed for a successful PR in my original comment. You ignored all of it and then you say this ? Enjoy your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants