Skip to content

PHP 8.5 | File::getMemberProperties(): add tests with asymmetric visibility for static properties #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+43 −6
Merged

PHP 8.5 | File::getMemberProperties(): add tests with asymmetric visibility for static properties #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/Core/Files/File/GetMemberPropertiesTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,12 @@ class AsymVisibility {
/* testPHP84AsymPrivateSetPublicProperty */
private(set) public mixed $prop9;

/* testPHP84IllegalAsymPublicProtectedSetStaticProperty */
public protected(set) static mixed $prop10;
/* testPHP85AsymPrivateSetStaticProperty */
private(set) static mixed $prop10;
/* testPHP85AsymFinalPublicProtectedSetStaticProperty */
final public protected(set) static Union|Type $prop11;
/* testPHP85AsymPublicSetStaticProperty */
static public(set) ?array $prop12;
}

abstract class WithAbstractProperties {
Expand Down
41 changes: 37 additions & 4 deletions tests/Core/Files/File/GetMemberPropertiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,12 +1667,12 @@ public static function dataGetMemberProperties()
'nullable_type' => false,
],
],
'php8.4-illegal-asym-public-protected-set-static' => [
'identifier' => '/* testPHP84IllegalAsymPublicProtectedSetStaticProperty */',
'php8.5-asym-private-set-static' => [
'identifier' => '/* testPHP85AsymPrivateSetStaticProperty */',
'expected' => [
'scope' => 'public',
'scope_specified' => true,
'set_scope' => 'protected',
'scope_specified' => false,
'set_scope' => 'private',
'is_static' => true,
'is_readonly' => false,
'is_final' => false,
Expand All @@ -1683,6 +1683,39 @@ public static function dataGetMemberProperties()
'nullable_type' => false,
],
],
'php8.5-asym-final-public-protected-set-static' => [
'identifier' => '/* testPHP85AsymFinalPublicProtectedSetStaticProperty */',
'expected' => [
'scope' => 'public',
'scope_specified' => true,
'set_scope' => 'protected',
'is_static' => true,
'is_readonly' => false,
'is_final' => true,
'is_abstract' => false,
'type' => 'Union|Type',
'type_token' => -4,
'type_end_token' => -2,
'nullable_type' => false,
],
],
'php8.5-asym-static-public-set' => [
'identifier' => '/* testPHP85AsymPublicSetStaticProperty */',
'expected' => [
'scope' => 'public',
'scope_specified' => false,
'set_scope' => 'public',
'is_static' => true,
'is_readonly' => false,
'is_final' => false,
'is_abstract' => false,
'type' => '?array',
'type_token' => -2,
'type_end_token' => -2,
'nullable_type' => true,
],
],

'php8.4-abstract-public-property' => [
'identifier' => '/* testPHP84AbstractPublicTypedProp */',
'expected' => [
Expand Down