Skip to content

Tests: data set keys should match parameter names #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Tests: data set keys should match parameter names #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/Core/Config/ReportWidthTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,18 +244,18 @@ public function testReportWidthInputHandlingForAuto()
/**
* Test that the report width will be set correctly for various types of input.
*
* @param mixed $input Input value received.
* @param mixed $value Input value received.
* @param int $expected Expected report width.
*
* @dataProvider dataReportWidthInputHandling
* @covers \PHP_CodeSniffer\Config::__set
*
* @return void
*/
public function testReportWidthInputHandling($input, $expected)
public function testReportWidthInputHandling($value, $expected)
{
$config = new Config();
$config->reportWidth = $input;
$config->reportWidth = $value;

$this->assertSame($expected, $config->reportWidth);

Expand Down
6 changes: 3 additions & 3 deletions tests/Core/ErrorSuppressionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,9 +730,9 @@ public static function dataSuppressFile()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedErrors' => 1,
'before' => '',
'after' => '',
'expectedWarnings' => 1,
],

// Process with suppression.
Expand Down
6 changes: 3 additions & 3 deletions tests/Core/File/IsReferenceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@ public function testNotBitwiseAndToken()
/**
* Test correctly identifying whether a "bitwise and" token is a reference or not.
*
* @param string $identifier Comment which precedes the test case.
* @param string $testMarker Comment which precedes the test case.
* @param bool $expected Expected function output.
*
* @dataProvider dataIsReference
*
* @return void
*/
public function testIsReference($identifier, $expected)
public function testIsReference($testMarker, $expected)
{
$bitwiseAnd = $this->getTargetToken($identifier, T_BITWISE_AND);
$bitwiseAnd = $this->getTargetToken($testMarker, T_BITWISE_AND);
$result = self::$phpcsFile->isReference($bitwiseAnd);
$this->assertSame($expected, $result);

Expand Down