Skip to content

Generic/LowerCaseConstant: move parse error test to its own file #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Generic/LowerCaseConstant: move parse error test to its own file #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4312057
Generic/LowerCaseConstant: rename unit test case file to allow for ad…
biinari Jul 13, 2024
0a4e8b9
Generic/LowerCaseConstant: move parse error test to its own file
biinari Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...c/Tests/PHP/LowerCaseConstantUnitTest.inc → ...Tests/PHP/LowerCaseConstantUnitTest.1.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,3 @@ class TypedConstants {

// Global constants can not be typed.
const MYCONST = TRUE;

// Last coding/parse error.
// This has to be the last test in the file.
function UnclosedCurly (): FALSE {
4 changes: 0 additions & 4 deletions ...s/PHP/LowerCaseConstantUnitTest.inc.fixed → ...PHP/LowerCaseConstantUnitTest.1.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,3 @@ class TypedConstants {

// Global constants can not be typed.
const MYCONST = true;

// Last coding/parse error.
// This has to be the last test in the file.
function UnclosedCurly (): FALSE {
4 changes: 4 additions & 0 deletions src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.2.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?php

// Intentional parse error. Testing that the sniff is *not* triggered in this case.
function UnclosedCurly (): FALSE {
2 changes: 1 addition & 1 deletion src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ final class LowerCaseConstantUnitTest extends AbstractSniffUnitTest
public function getErrorList($testFile='')
{
switch ($testFile) {
case 'LowerCaseConstantUnitTest.inc':
case 'LowerCaseConstantUnitTest.1.inc':
return [
7 => 1,
10 => 1,
Expand Down