Skip to content

Squiz/PropertyDeclaration: add fixer for 'var' keyword #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Squiz/PropertyDeclaration: add fixer for 'var' keyword #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Standards/PSR2/Sniffs/Classes/PropertyDeclarationSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ protected function processMemberVar(File $phpcsFile, $stackPtr)

if ($tokens[$prev]['code'] === T_VAR) {
$error = 'The var keyword must not be used to declare a property';
$phpcsFile->addError($error, $stackPtr, 'VarUsed');
$fix = $phpcsFile->addFixableError($error, $stackPtr, 'VarUsed');
if ($fix === true) {
$phpcsFile->fixer->replaceToken($prev, 'public');
}
}

$next = $phpcsFile->findNext([T_VARIABLE, T_SEMICOLON], ($stackPtr + 1));
Expand Down
6 changes: 3 additions & 3 deletions src/Standards/PSR2/Tests/Classes/PropertyDeclarationUnitTest.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ class MyClass
private $var = null;
$var = null;

var $var = null;
public $var = null;
static $var = null;
public var $var = null; // Parse error.
public public $var = null; // Parse error.

public $_var = null;
protected $_var = null;
Expand Down Expand Up @@ -46,7 +46,7 @@ class MyClass
public string $var = null;
protected ?Folder\ClassName $var = null;

var int $var = null;
public int $var = null;
static int $var = null;

private int $_var = null;
Expand Down
Loading