Generic/OpeningFunctionBrace*: check spacing before brace for empty functions

[jrfnl]

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3869:

Basically this is the same fix for both sniffs. The sniffs would return, instead of skip over a particular check, which meant that other checks after the check which needed to be skipped were not being run.

Generic/OpeningFunctionBraceKernighanRitchie: check spacing before brace for empty functions

As things were, when an empty function was detected, the sniff would bow out and not execute the "SpaceBeforeBrace" check.

Fixed now.

Includes tests.

Generic/OpeningFunctionBraceBsdAllman: check spacing before brace for empty functions

As things were, when an empty function was detected, the sniff would bow out and not execute the "BraceIndent" check.

Fixed now.

Includes tests.

Suggested changelog entry

• Generic/OpeningFunctionBraceKernighanRitchie: spacing before opening brace will now also be checked for empty functions
• Generic/OpeningFunctionBraceBsdAllman: brace indent will now also be checked for empty functions

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement