Skip to content

MessageCollectorTest: data providers should be static #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

MessageCollectorTest: data providers should be static #878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/Core/Util/MessageCollector/MessageCollectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function testAddingNonStringMessageResultsInException($message)
*
* @return array<string, array<mixed>>
*/
public function dataAddingNonStringMessageResultsInException()
public static function dataAddingNonStringMessageResultsInException()
{
return [
'null' => [null],
Expand Down Expand Up @@ -103,7 +103,7 @@ public function testAddingMessageWithUnsupportedMessageTypeResultsInException($t
*
* @return array<string, array<mixed>>
*/
public function dataAddingMessageWithUnsupportedMessageTypeResultsInException()
public static function dataAddingMessageWithUnsupportedMessageTypeResultsInException()
{
return [
'null' => [null],
Expand Down Expand Up @@ -150,7 +150,7 @@ public function testContainsBlockingErrors($messages, $expected)
*
* @return array<string, array<string, array<string, int>|bool>>
*/
public function dataContainsBlockingErrors()
public static function dataContainsBlockingErrors()
{
return [
'No messages' => [
Expand Down Expand Up @@ -221,7 +221,7 @@ public function testDisplayingNonBlockingMessages($messages, $expected)
*
* @return array<string, array<string, array<string, int>|string>>
*/
public function dataDisplayingNonBlockingMessages()
public static function dataDisplayingNonBlockingMessages()
{
// phpcs:disable Squiz.Strings.ConcatenationSpacing.PaddingFound -- Test readability is more important.
return [
Expand Down Expand Up @@ -333,7 +333,7 @@ public function testDisplayingBlockingErrors($messages, $expected)
*
* @return array<string, array<string, array<string, int>|string>>
*/
public function dataDisplayingBlockingErrors()
public static function dataDisplayingBlockingErrors()
{
// phpcs:disable Squiz.Strings.ConcatenationSpacing.PaddingFound -- Test readability is more important.
return [
Expand Down Expand Up @@ -488,7 +488,7 @@ public function testDisplayOrderHandling($order, $expected)
*
* @return array<string, array<string, string>>
*/
public function dataDisplayOrderHandling()
public static function dataDisplayOrderHandling()
{
$expectedForSeverity = 'WARNING: Fourth warning'.PHP_EOL;
$expectedForSeverity .= 'NOTICE: First notice'.PHP_EOL;
Expand Down