Conversation
… with `final` properties Turns out there are tokenizer changes needed to support `final` properties as the retokenization of `|` to `T_TYPE_UNION`, `&` to T_TYPE_INTERSECTION` and the parenthesis in DNF types to `T_TYPE_*_PARENTHESIS` was broken. Fixed now. Includes tests.
Member
Author
|
@DanielEScherzer Would you like to review this PR ? |
DanielEScherzer
approved these changes
Mar 28, 2025
Contributor
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Code looks good to me, but the syntax highlighting in the PR description could use some improvement
Member
Author
Fixed. Reason I found this was cause I was looking at the asym visibility PR. A similar change will be needed in that PR to allow for the type tokens to be handled correctly in combination with asym visibility. The change I made in PR #908 is also related and a similar change may be needed in the asym PR. |
11 tasks
This was referenced Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turns out there are tokenizer changes needed to support
finalproperties as the retokenization of|toT_TYPE_UNION,&toT_TYPE_INTERSECTIONand the parenthesis in DNF types toT_TYPE_*_PARENTHESISwas broken.Fixed now.
Includes tests.
Suggested changelog entry
Fixed tokenization of union/intersection and DNF types in combination with PHP 8.4
finalproperties.Related issues/external references
Related to #734 and #834