Tests: introduce new AbstractRealConfigTestCase
#909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `Config` class contains a number of `static` properties, it is important to avoid tests influencing each other if the tests would cause changes to the value of the static properties. This was already handled correctly in the two places were the _real_ `Config` class is being used in the tests, but that meant those test classes now contain duplicate code. This new `AbstractRealConfigTestCase` class removes that code duplication. This test case should be used in the rare circumstances that the _real_ `Config` class needs to be used in the tests. In most cases, using the `ConfigDouble` class is much preferred, but for select tests for the `Config` class itself + for tests involving the `Runner` class, using the real `Config` class cannot be avoided.
jrfnl
force-pushed
the
feature/tests-add-abstract-real-config-testcase
branch
from
7a72e88 to
c157dc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the
Configclass contains a number ofstaticproperties, it is important to avoid tests influencing each other if the tests would cause changes to the value of the static properties.This was already handled correctly in the two places were the real
Configclass is being used in the tests, but that meant those test classes now contain duplicate code.This new
AbstractRealConfigTestCaseclass removes that code duplication.This test case should be used in the rare circumstances that the real
Configclass needs to be used in the tests.In most cases, using the
ConfigDoubleclass is much preferred, but for select tests for theConfigclass itself + for tests involving theRunnerclass, using the realConfigclass cannot be avoided.Suggested changelog entry
N/A