Skip to content

File::getMethodParameters(): add extra test #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

File::getMethodParameters(): add extra test #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/Core/File/GetMethodParametersTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,9 @@ function() use() {};
/* testClosureUse */
function() use( $foo, $bar ) {};

/* testClosureUseWithReference */
$cl = function() use (&$foo, &$bar) {};

/* testFunctionParamListWithTrailingComma */
function trailingComma(
?string $foo /*comment*/ ,
Expand Down
45 changes: 45 additions & 0 deletions tests/Core/File/GetMethodParametersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2935,6 +2935,51 @@ public function testClosureUse()
}//end testClosureUse()


/**
* Verify handling of a closure T_USE token with variables imported by reference.
*
* @return void
*/
public function testClosureUseWithReference()
{
// Offsets are relative to the T_USE token.
$expected = [];
$expected[0] = [
'token' => 4,
'name' => '$foo',
'content' => '&$foo',
'has_attributes' => false,
'pass_by_reference' => true,
'reference_token' => 3,
'variable_length' => false,
'variadic_token' => false,
'type_hint' => '',
'type_hint_token' => false,
'type_hint_end_token' => false,
'nullable_type' => false,
'comma_token' => 5,
];
$expected[1] = [
'token' => 8,
'name' => '$bar',
'content' => '&$bar',
'has_attributes' => false,
'pass_by_reference' => true,
'reference_token' => 7,
'variable_length' => false,
'variadic_token' => false,
'type_hint' => '',
'type_hint_token' => false,
'type_hint_end_token' => false,
'nullable_type' => false,
'comma_token' => false,
];

$this->getMethodParametersTestHelper('/* '.__FUNCTION__.' */', $expected, [T_USE]);

}//end testClosureUseWithReference()


/**
* Verify function declarations with trailing commas are handled correctly.
*
Expand Down