Skip to content

Generic/[Lower|Upper]CaseConstant: minor test clean up #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Generic/[Lower|Upper]CaseConstant: minor test clean up #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ $input->getFilterChain()->attachByName('Null', ['type' => Null::TYPE_STRING]);

// Issue #3332 - ignore type declarations, but not default values.
class TypedThings {
const MYCONST = FALSE;
const MYCONST = FALSE;

public int|FALSE $int = FALSE;
public Type|NULL $int = new MyObj(NULL);
public int|FALSE $int = FALSE;
public Type|NULL $int = new MyObj(NULL);

private function typed(int|FALSE $param = NULL, Type|NULL $obj = new MyObj(FALSE)) : string|FALSE|NULL
{
if (TRUE === FALSE) {
return NULL;
private function typed(int|FALSE $param = NULL, Type|NULL $obj = new MyObj(FALSE)) : string|FALSE|NULL
{
if (TRUE === FALSE) {
return NULL;
}
}
}
Expand Down
14 changes: 7 additions & 7 deletions src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.1.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ $input->getFilterChain()->attachByName('Null', ['type' => Null::TYPE_STRING]);

// Issue #3332 - ignore type declarations, but not default values.
class TypedThings {
const MYCONST = false;
const MYCONST = false;

public int|FALSE $int = false;
public Type|NULL $int = new MyObj(null);
public int|FALSE $int = false;
public Type|NULL $int = new MyObj(null);

private function typed(int|FALSE $param = null, Type|NULL $obj = new MyObj(false)) : string|FALSE|NULL
{
if (true === false) {
return null;
private function typed(int|FALSE $param = null, Type|NULL $obj = new MyObj(false)) : string|FALSE|NULL
{
if (true === false) {
return null;
}
}
}
Expand Down
14 changes: 7 additions & 7 deletions src/Standards/Generic/Tests/PHP/UpperCaseConstantUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ function true() {}

// Issue #3332 - ignore type declarations, but not default values.
class TypedThings {
const MYCONST = false;
const MYCONST = false;

public int|false $int = false;
public Type|null $int = new MyObj(null);
public int|false $int = false;
public Type|null $int = new MyObj(null);

private function typed(int|false $param = null, Type|null $obj = new MyObj(false)) : string|false|null
{
if (true === false) {
return null;
private function typed(int|false $param = null, Type|null $obj = new MyObj(false)) : string|false|null
{
if (true === false) {
return null;
}
}
}
Expand Down
14 changes: 7 additions & 7 deletions src/Standards/Generic/Tests/PHP/UpperCaseConstantUnitTest.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ function true() {}

// Issue #3332 - ignore type declarations, but not default values.
class TypedThings {
const MYCONST = FALSE;
const MYCONST = FALSE;

public int|false $int = FALSE;
public Type|null $int = new MyObj(NULL);
public int|false $int = FALSE;
public Type|null $int = new MyObj(NULL);

private function typed(int|false $param = NULL, Type|null $obj = new MyObj(FALSE)) : string|false|null
{
if (TRUE === FALSE) {
return NULL;
private function typed(int|false $param = NULL, Type|null $obj = new MyObj(FALSE)) : string|false|null
{
if (TRUE === FALSE) {
return NULL;
}
}
}
Expand Down