Skip to content

TokenNameTest: ensure all polyfilled tokens are tested #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

TokenNameTest: ensure all polyfilled tokens are tested #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Util/Tokens.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@
define('T_TYPE_OPEN_PARENTHESIS', 'PHPCS_T_TYPE_OPEN_PARENTHESIS');
define('T_TYPE_CLOSE_PARENTHESIS', 'PHPCS_T_TYPE_CLOSE_PARENTHESIS');

/*
* {@internal IMPORTANT: all PHP native polyfilled tokens MUST be added to the
* `PHP_CodeSniffer\Tests\Core\Util\Tokens\TokenNameTest::dataPolyfilledPHPNativeTokens()` test method!}
*/

// Some PHP 5.5 tokens, replicated for lower versions.
if (defined('T_FINALLY') === false) {
define('T_FINALLY', 'PHPCS_T_FINALLY');
Expand Down
103 changes: 103 additions & 0 deletions tests/Core/Util/Tokens/TokenNameTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ final class TokenNameTest extends TestCase
* @param string $expected The expected token name.
*
* @dataProvider dataTokenName
* @dataProvider dataPolyfilledPHPNativeTokens
*
* @return void
*/
Expand Down Expand Up @@ -78,4 +79,106 @@ public static function dataTokenName()
}//end dataTokenName()


/**
* Data provider.
*
* @return array<string, array<string, int|string>>
*/
public static function dataPolyfilledPHPNativeTokens()
{
return [
'PHP 5.5 native token, polyfilled: T_FINALLY' => [
'tokenCode' => T_FINALLY,
'expected' => 'T_FINALLY',
],
'PHP 5.5 native token, polyfilled: T_YIELD' => [
'tokenCode' => T_YIELD,
'expected' => 'T_YIELD',
],

'PHP 5.6 native token, polyfilled: T_ELLIPSIS' => [
'tokenCode' => T_ELLIPSIS,
'expected' => 'T_ELLIPSIS',
],
'PHP 5.6 native token, polyfilled: T_POW' => [
'tokenCode' => T_POW,
'expected' => 'T_POW',
],
'PHP 5.6 native token, polyfilled: T_POW_EQUAL' => [
'tokenCode' => T_POW_EQUAL,
'expected' => 'T_POW_EQUAL',
],

'PHP 7.0 native token, polyfilled: T_SPACESHIP' => [
'tokenCode' => T_SPACESHIP,
'expected' => 'T_SPACESHIP',
],
'PHP 7.0 native token, polyfilled: T_COALESCE' => [
'tokenCode' => T_COALESCE,
'expected' => 'T_COALESCE',
],
'PHP 7.0 native token, polyfilled: T_YIELD_FROM' => [
'tokenCode' => T_YIELD_FROM,
'expected' => 'T_YIELD_FROM',
],

'PHP 7.4 native token, polyfilled: T_COALESCE_EQUAL' => [
'tokenCode' => T_COALESCE_EQUAL,
'expected' => 'T_COALESCE_EQUAL',
],
'PHP 7.4 native token, polyfilled: T_BAD_CHARACTER' => [
'tokenCode' => T_BAD_CHARACTER,
'expected' => 'T_BAD_CHARACTER',
],
'PHP 7.4 native token, polyfilled: T_FN' => [
'tokenCode' => T_FN,
'expected' => 'T_FN',
],

'PHP 8.0 native token, polyfilled: T_NULLSAFE_OBJECT_OPERATOR' => [
'tokenCode' => T_NULLSAFE_OBJECT_OPERATOR,
'expected' => 'T_NULLSAFE_OBJECT_OPERATOR',
],
'PHP 8.0 native token, polyfilled: T_NAME_QUALIFIED' => [
'tokenCode' => T_NAME_QUALIFIED,
'expected' => 'T_NAME_QUALIFIED',
],
'PHP 8.0 native token, polyfilled: T_NAME_FULLY_QUALIFIED' => [
'tokenCode' => T_NAME_FULLY_QUALIFIED,
'expected' => 'T_NAME_FULLY_QUALIFIED',
],
'PHP 8.0 native token, polyfilled: T_NAME_RELATIVE' => [
'tokenCode' => T_NAME_RELATIVE,
'expected' => 'T_NAME_RELATIVE',
],
'PHP 8.0 native token, polyfilled: T_MATCH' => [
'tokenCode' => T_MATCH,
'expected' => 'T_MATCH',
],
'PHP 8.0 native token, polyfilled: T_ATTRIBUTE' => [
'tokenCode' => T_ATTRIBUTE,
'expected' => 'T_ATTRIBUTE',
],

'PHP 8.1 native token, polyfilled: T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG' => [
'tokenCode' => T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG,
'expected' => 'T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG',
],
'PHP 8.1 native token, polyfilled: T_AMPERSAND_NOT_FOLLOWED_BY_VAR_OR_VARARG' => [
'tokenCode' => T_AMPERSAND_NOT_FOLLOWED_BY_VAR_OR_VARARG,
'expected' => 'T_AMPERSAND_NOT_FOLLOWED_BY_VAR_OR_VARARG',
],
'PHP 8.1 native token, polyfilled: T_READONLY' => [
'tokenCode' => T_READONLY,
'expected' => 'T_READONLY',
],
'PHP 8.1 native token, polyfilled: T_ENUM' => [
'tokenCode' => T_ENUM,
'expected' => 'T_ENUM',
],
];

}//end dataPolyfilledPHPNativeTokens()


}//end class