Generators: remove deprecated methods #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods were _soft_ deprecated in PHPCS 3.12.0 via PR 755 and hard deprecated in PHPCS 3.x via PR 889. Includes removing the associated tests which verified the deprecation notice was being thrown. Related to 6
jrfnl
force-pushed
the
phpcs-4.0/feature/generators-remove-deprecated-methods
branch
from
56f4085 to
f79d50b
Compare
fredden
approved these changes
Apr 14, 2025
rodrigoprimo
approved these changes
Apr 14, 2025
jrfnl
deleted the
phpcs-4.0/feature/generators-remove-deprecated-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These methods were soft deprecated in PHPCS 3.12.0 via PR #755 and hard deprecated in PHPCS 3.x via PR #889.
Includes removing the associated tests which verified the deprecation notice was being thrown.
Related to #6
Suggested changelog entry
Removed
The deprecated
PHP_CodeSniffer\Generators\[HTML|Markdown|Text]::print*()methods.