Ruleset: remove support for sniffs nor implementing Sniff interface
#986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously truly invalid sniffs would already be ignored/rejected, but sniffs which didn't implement the interface, but did implement the required methods would still be accepted. Now, both will be rejected. Includes removing the `RegisterSniffsRejectsInvalidSniffTest` class as these tests are now redundant (covered via the `RegisterSniffsMissingInterfaceTest` class). This commit executes step 4 to address issue 694.. Closes 694 Related to 6
rodrigoprimo
approved these changes
Apr 14, 2025
jrfnl
deleted the
phpcs-4.0/feature/694-4-ruleset-dont-allow-sniffs-not-implementing-sniff-interface
branch
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously truly invalid sniffs would already be ignored/rejected, but sniffs which didn't implement the interface, but did implement the required methods would still be accepted.
Now, both will be rejected.
Includes removing the
RegisterSniffsRejectsInvalidSniffTestclass as these tests are now redundant (covered via theRegisterSniffsMissingInterfaceTestclass).This commit executes step 4 to address issue #694.
Suggested changelog entry
Removed:
PHP_CodeSniffer\Sniffs\Sniffinterface.Related issues/external references
Closes #694
Related to #6