Skip to content

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 21, 2025

PHPCompatibilitySymfonyPolyfillPHP56: update ruleset for PHPCompatibility 10.0-alpha1

Looks like one function call would at the very least run into a warning: https://3v4l.org/v3mZE
Having said that, it would need a combination of Mbstring function overload being into effect + Mbstring not being available for this warning to be hit, which is probably why nobody ever reported it to Symfony.

All in all, not our concern, but a bug in the Polyfill, so let's just ignore it.

PHPCompatibilitySymfonyPolyfillPHP72: update ruleset for PHPCompatibility 10.0-alpha1

Two of the polyfilled functions have since been deprecated by PHP itself. As they are polyfilled by the Symfony PHP 7.2 polyfill, we can ignore the deprecation though.

Includes bug fix for a faulty test.

PHPCompatibilitySymfonyPolyfillPHP80: update ruleset for PHPCompatibility 10.0-alpha1

As of PHPCompatibility 10.0.0, we detect and handle the use of PHP 8.0 attributes (though I expect how to still change a little more).
In this case, an attribute is applied to the polyfill for the Attribute class, so we need to ignore that attribute ;-)

Version 2.0.0-alpha1 / Update for PHPCompatibility 10.0.0-alpha1

This update accounts for the following changes:

  • Composer:
    • Update the version for the PHPCompatibility dependency.
      The @dev version number suffix should ensure that the PHPCompatibility 10.0.0-alpha1 version can be installed, even if the project minimum stability does not specifically allow for dev versions.
    • Remove the DealerDirect Composer PHPCS plugin dependency.
      This plugin will now automatically be installed as it is a dependency of PHPCSUtils and therefore of PHPCompatibility itself.
      Not having it set as an explicit dependency here, will prevent potential future conflicts with the supported versions of the plugin.
    • Removed the suggest section.
      The DealerDirect plugin no longer needs to be suggested and after two years, people should have gotten the message about using the roave/security-advisories.
  • Readme:
    • Updated the minimum PHP and PHPCS requirements.
    • Updated the installation instructions for the 2.0.0-alpha1 release (being a dev release).
    • Updated the installation instructions to no longer mention adding a Composer plugin to sort out the PHPCS installed_paths.
    • Added upgrade instructions.
    • Added section about funding.
    • Use link list for links used multiple times.
    • Minor other tweaks after critical read-through of the README.
  • CI:
    • Continue testing against dev-develop.
    • Prevent builds failing on low PHP versions on the recommendation to use a more recent PHP version.

jrfnl added 4 commits October 21, 2025 23:52
…lity 10.0-alpha1

Looks like one function call would at the very least run into a warning: https://3v4l.org/v3mZE
Having said that, it would need a combination of Mbstring function overload being into effect + Mbstring not being available for this warning to be hit, which is probably why nobody ever reported it to Symfony.

All in all, not our concern, but a bug in the Polyfill, so let's just ignore it.
…lity 10.0-alpha1

Two of the polyfilled functions have since been deprecated by PHP itself. As they are polyfilled by the Symfony PHP 7.2 polyfill, we can ignore the deprecation though.

Includes bug fix for a faulty test.
…lity 10.0-alpha1

As of PHPCompatibility 10.0.0, we detect and handle the use of PHP 8.0 attributes (though I expect _how_ to still change a little more).
In this case, an attribute is applied to the polyfill for the `Attribute` class, so we need to ignore that attribute ;-)
This update accounts for the following changes:
* Composer:
    - Update the version for the PHPCompatibility dependency.
        The `@dev` version number suffix should ensure that the PHPCompatibility 10.0.0-alpha1 version can be installed, even if the project minimum stability does not specifically allow for dev versions.
    - Remove the DealerDirect Composer PHPCS plugin dependency.
        This plugin will now automatically be installed as it is a dependency of PHPCSUtils and therefore of PHPCompatibility itself.
        Not having it set as an explicit dependency here, will prevent potential future conflicts with the supported versions of the plugin.
    - Removed the `suggest` section.
        The DealerDirect plugin no longer needs to be suggested and after two years, people should have gotten the message about using the `roave/security-advisories`.
* Readme:
    - Updated the minimum PHP and PHPCS requirements.
    - Updated the installation instructions for the 2.0.0-alpha1 release (being a dev release).
    - Updated the installation instructions to no longer mention adding a Composer plugin to sort out the PHPCS `installed_paths`.
    - Added upgrade instructions.
    - Added section about funding.
    - Use link list for links used multiple times.
    - Minor other tweaks after critical read-through of the README.
* CI:
    - Continue testing against `dev-develop`.
    - Prevent builds failing on low PHP versions on the recommendation to use a more recent PHP version.
@jrfnl jrfnl added this to the 2.0.0-alpha1 milestone Oct 21, 2025
@jrfnl jrfnl merged commit 69d23c0 into master Oct 21, 2025
6 checks passed
@jrfnl jrfnl deleted the feature/update-for-phpcompatibility-10.0.0-alpha1 branch October 21, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant