Add PHPCompatibilitySymfonyPolyfillPHP83 ruleset
#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Symfony project has released a [polyfill library for PHP 8.3](https://github.com/symfony/polyfill-php83) and what with the release of PHPCompatibility 10.0.0-alpha1, features polyfilled by that library would now be flagged. This adds a corresponding PHPCompatibility ruleset for this polyfill. Includes integration test. Note: while creating this polyfill ruleset, PHPCompatibility found two PHP cross-version compatibility bugs in the actual polyfills ;-) These have both been reported upstream. Bug reports: * symfony/polyfill 499#issuecomment-3430297592 * symfony/polyfill 550 Additionally, PHPCompatibility correctly detected that the PHP 8.3 polyfills were not in actual fact compatible with PHP 7.1. This was "fixed" in version 1.31.0 when support for PHP 7.1 was dropped.
jrfnl
force-pushed
the
feature/new-php83-polyfill-ruleset
branch
from
ad50f08 to
47a180a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symfony project has released a polyfill library for PHP 8.3 and what with the release of PHPCompatibility 10.0.0-alpha1, features polyfilled by that library would now be flagged.
This adds a corresponding PHPCompatibility ruleset for this polyfill.
Includes integration test.
Note: while creating this polyfill ruleset, PHPCompatibility found two PHP cross-version compatibility bugs in the actual polyfills ;-)
These have both been reported upstream.
Bug reports:
ValueErrorclass not available in PHP < 8 symfony/polyfill#499#issuecomment-3430297592Additionally, PHPCompatibility correctly detected that the PHP 8.3 polyfills were not in actual fact compatible with PHP 7.1. This was "fixed" in version 1.31.0 when support for PHP 7.1 was dropped.