Skip to content

Fix rowspans for tables in HTML Writer #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix rowspans for tables in HTML Writer #2163

wants to merge 1 commit into from

Conversation

andomiell
Copy link
Contributor

Description

Considering colspans when calculating rowspans.

Before:

image

After:

image

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@simogeo simogeo mentioned this pull request Feb 18, 2022
Open
@PowerKiKi PowerKiKi changed the base branch from develop to master November 16, 2022 21:15
@Progi1984 Progi1984 force-pushed the master branch 3 times, most recently from 2d9f999 to e458249 Compare August 30, 2023 11:56
@Progi1984 Progi1984 added this to the 1.3.0 milestone Aug 20, 2024
@Progi1984
Copy link
Member

Superseeded by #2659

@Progi1984 Progi1984 closed this Aug 26, 2024
@Progi1984 Progi1984 mentioned this pull request Aug 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andomiell @Progi1984