Skip to content

Conversation

glafarge
Copy link
Contributor

@glafarge glafarge commented Jun 4, 2024

Description

Replace hardcoded macro chars by the customized ones in deleteRow() method of TemplateProcessor class

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

Coverage Status

coverage: 97.208%. remained the same
when pulling eb4dd2e on glafarge:patch-1
into 2daa50c on PHPOffice:master.

@Progi1984
Copy link
Member

@glafarge Could you update the changelog, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 7, 2024
@glafarge
Copy link
Contributor Author

glafarge commented Aug 7, 2024

@Progi1984 Done 😉

@Progi1984 Progi1984 merged commit b99230a into PHPOffice:master Aug 7, 2024
12 checks passed
@Progi1984 Progi1984 added Template Processor and removed Status: Waiting for feedback Question has been asked, waiting for response from PR author labels Aug 7, 2024
@Progi1984 Progi1984 added this to the 2.0.0 milestone Aug 7, 2024
@Progi1984
Copy link
Member

Thanks @glafarge ☺️

@coveralls
Copy link

Coverage Status

coverage: 97.211% (+0.003%) from 97.208%
when pulling 827a570 on glafarge:patch-1
into 2daa50c on PHPOffice:master.

@glafarge glafarge deleted the patch-1 branch September 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants