Skip to content

RTF: Fix Header.php registerFont() not registering fonts/colors in subElements (such as textRuns) #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RTF: Fix Header.php registerFont() not registering fonts/colors in subElements (such as textRuns) #2818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e69ea9
Fix Header.php registerFont()
rasamassen Sep 1, 2025
dd9111c
Update Header.php - Fix formatting
rasamassen Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/PhpWord/Writer/RTF/Part/Header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,14 @@
if (method_exists($element, 'getFontStyle')) {
$style = $element->getFontStyle();
$this->registerFontItems($style);
} elseif (method_exists($element, 'getElements')) {
$textRuns = $element->getElements();
foreach ($textRuns as $textRun) {
if (method_exists($textRun, 'getFontStyle')) {
$style = $textRun->getFontStyle();

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (8.0) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (8.2) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (8.3) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (7.2) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (8.1) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (7.4) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (8.4) 

Cannot call method getFontStyle() on class-string|object.

Check failure on line 211 in src/PhpWord/Writer/RTF/Part/Header.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis (7.3) 

Cannot call method getFontStyle() on class-string|object.
$this->registerFontItems($style);
}
}
}
}
}
Expand Down
Loading