Skip to content

Commit 819854a

Browse files
committed
Upgrade PhpUnit
To a version which is aware that Php8.4 deprecates E_STRICT.
1 parent db89fe2 commit 819854a

File tree

3 files changed

+56
-60
lines changed

3 files changed

+56
-60
lines changed

composer.lock

Lines changed: 55 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/PhpSpreadsheetTests/Chart/ChartsDynamicTitleTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
use PhpOffice\PhpSpreadsheet\Writer\Xlsx as XlsxWriter;
1818
use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;
1919

20-
/**
21-
* Seems to need to be separate for Php8.4 PhpUnit9 combination.
22-
*
23-
* @runTestsInSeparateProcesses
24-
*/
2520
class ChartsDynamicTitleTest extends AbstractFunctional
2621
{
2722
protected function tearDown(): void

tests/bootstrap.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function phpunit10ErrorHandler(int $errno, string $errstr, string $filename, int
3535
return false; // continue error handling
3636
}
3737

38-
if (!method_exists(PHPUnit\Framework\TestCase::class, 'setOutputCallback') || PHP_VERSION_ID >= 80400) {
38+
if (!method_exists(PHPUnit\Framework\TestCase::class, 'setOutputCallback')) {
3939
ini_set('error_reporting', (string) E_ALL);
4040
set_error_handler('phpunit10ErrorHandler');
4141
}

0 commit comments

Comments
 (0)