Skip to content

Cell Coordinate splitRange doesn't support space delimeter #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

mcouillard
Copy link

@mcouillard mcouillard commented May 1, 2020

This is: new feature to support spaced coordinates instead of just comma delimited lists. Specific to the splitRange() method.
Issue #1457

- [ ] a bugfix
- [X] a new feature

Checklist:

Why this change is needed?

Excel can save protection ranges as a spaced list instead of just a comma list.

@mcouillard mcouillard changed the title Cell Coordinate splitRange doesn't support space delimeter #1457 Cell Coordinate splitRange doesn't support space delimeter May 1, 2020
@MarkBaker
Copy link
Member

You're right that a space can appear in a range definition; but it isn't simply an alternative for a comma.
Both space and comma are operators in a range definition:

  • A comma is the Union operator (combines two references into a single reference)
  • A space is the Intersection operator (returns a reference to the intersection of two ranges)
    So I need to take a much more detailed look at how well PHPSpreadsheet handles this difference when it is used.

@mcouillard
Copy link
Author

That makes more sense! My solution didn't feel optimal and I couldn't find the right doc from Microsoft or about OpenXML to determine what these spaces here actually meant.

I appreciate your help.

@MarkBaker
Copy link
Member

He, yes! It's pretty obscure: simple example is to fill cells A1 to C3 with the values 1 to 9, then to have a couple of formulae: =SUM(A1:B2,B2:C3) and =SUM(A1:B2 B2:C3) and look at the different results.
I'll try putting some tests together tonight to see what the effects will be.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Oct 4, 2020
@stale stale bot closed this Oct 12, 2020
@oleibman
Copy link
Collaborator

Superseded by PR #4580. Removing stale label, leaving closed.

@oleibman oleibman removed the stale label Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants