Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/PhpSpreadsheet/Reader/Xlsx.php
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,19 @@ protected function loadSpreadsheetFromFile(string $filename): Spreadsheet

$charts = $chartDetails = [];

// Add richData (contains relation of in-cell images)
$richData = [];
$relationsFileName = $dir . '/richData/_rels/richValueRel.xml.rels';
if ($zip->locateName($relationsFileName)) {
$relsWorksheet = $this->loadZip($relationsFileName, Namespaces::RELATIONSHIPS);
foreach ($relsWorksheet->Relationship as $elex) {
$ele = self::getAttributes($elex);
if ($ele['Type'] == Namespaces::IMAGE) {
$richData['image'][(string) $ele['Id']] = (string) $ele['Target'];
}
}
}

$sheetCreated = false;
if ($xmlWorkbookNS->sheets) {
foreach ($xmlWorkbookNS->sheets->sheet as $eleSheet) {
Expand Down Expand Up @@ -940,6 +953,28 @@ protected function loadSpreadsheetFromFile(string $filename): Spreadsheet

break;
case DataType::TYPE_ERROR:
if (isset($cAttr->vm, $richData['image']['rId' . $cAttr->vm]) && !$useFormula) {
$imagePath = $dir . '/' . str_replace('../', '', $richData['image']['rId' . $cAttr->vm]);
$objDrawing = new \PhpOffice\PhpSpreadsheet\Worksheet\Drawing();
$objDrawing->setPath(
'zip://' . File::realpath($filename) . '#' . $imagePath,
false,
$zip
);

$objDrawing->setCoordinates($r);
$objDrawing->setOffsetX(0);
$objDrawing->setOffsetY(0);
$objDrawing->setResizeProportional(false);
$objDrawing->setWorksheet($docSheet);

$value = $objDrawing;
$cellDataType = DataType::TYPE_NULL;
$c->t = DataType::TYPE_NULL;

break;
}

if (!$useFormula) {
$value = self::castToError($c);
} else {
Expand Down
36 changes: 36 additions & 0 deletions tests/PhpSpreadsheetTests/Reader/Xlsx/DrawingInCellTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?php

declare(strict_types=1);

namespace PhpOffice\PhpSpreadsheetTests\Reader\Xlsx;

use PhpOffice\PhpSpreadsheet\Reader\Xlsx;
use PHPUnit\Framework\TestCase;

class DrawingInCellTest extends TestCase
{
public function testPictureInCell(): void
{
$file = 'tests/data/Reader/XLSX/drawing_in_cell.xlsx';
$reader = new Xlsx();
$spreadsheet = $reader->load($file);
$sheet = $spreadsheet->getActiveSheet();
$drawings = $sheet->getDrawingCollection();
self::assertCount(1, $drawings);

if ($drawings[0] === null) {
self::fail('Unexpected null drawing');
} else {
self::assertSame(IMAGETYPE_PNG, $drawings[0]->getType());
self::assertSame('B2', $drawings[0]->getCoordinates());
self::assertSame(0, $drawings[0]->getOffsetX());
self::assertSame(0, $drawings[0]->getOffsetY());
self::assertSame(296, $drawings[0]->getWidth());
self::assertSame(154, $drawings[0]->getHeight());
self::assertSame(296, $drawings[0]->getImageWidth());
self::assertSame(154, $drawings[0]->getImageHeight());
}

$spreadsheet->disconnectWorksheets();
}
}
Binary file added tests/data/Reader/XLSX/drawing_in_cell.xlsx
Binary file not shown.