Skip to content

RWA 1070#31

Open
nic10ben wants to merge 10 commits intomasterfrom
RWA-1070
Open

RWA 1070#31
nic10ben wants to merge 10 commits intomasterfrom
RWA-1070

Conversation

@nic10ben
Copy link
Contributor

@mseaton I made some changes related to the voucher creation you can review them.

@nic10ben nic10ben requested a review from mseaton January 30, 2026 13:35
@nic10ben
Copy link
Contributor Author

@mseaton focus on the last three commits

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at my comments @nic10ben . I merged up master into this branch so that only the changes you are making are shown in the diff...

policy.setInsurance(insurance);
policy.setOwner(policyModel.getOwner());
policy.setInsuranceCardNo(policyModel.getInsuranceCardNo());
policy.setRhipPatientId(policyModel.getRhipPatientId());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make a note - this does not compile for me, as the necessary changes to the billing module are not committed yet and are also not in maven. So the billing module will need it's changes made and committed and built before we can merge this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq("#verify-button").removeAttr("disabled");
jq("#verify-button").click();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this - I think we need to look at what the toggleVerificationButton is doing, as it is the primary place where the logic lives as to whether to enable or disable the button. So I wouldn't put logic in here to remove the disabled attribute from the button - that should be handled in the toggleVerificationButton method if appropriate.

Not entirely sure what you are trying to do here, but it seems like you are not enabling the verification button if an rhipPatientId is already present? And then you are also automatically clicking on this button once the page loads in edit mode? Can you clarify what you are trying to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants