include project directory with target instead of globally#341
Merged
PJK merged 1 commit intoPJK:masterfrom Mar 4, 2025
Merged
Conversation
Owner
|
Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 30, 2025
0.12.0 (2025-03-16) - BUILD BREAKING: [Respect `INTERPROCEDURAL_OPTIMIZATION` and use the default value](PJK/libcbor#315) - BREAKING: Changes to NaN encoding - [Fix NaN encoding on Windows](PJK/libcbor#271) - [Fix NaN encoding on mips/mipsel](PJK/libcbor#329) - [Signaling NaNs will from now on be encoded as canonical quiet NaNs](PJK/libcbor#335). This was already the existing behavior for half-precision floats - Decoding is unchanged - Please note that this is an intermediate state and likely to be revisited (PJK/libcbor#336) - [Make build compatible with CMake FetchContent](PJK/libcbor#341) (by [Jan200101](https://github.com/Jan200101)) - [Support Bzlmod for Bazel builds](PJK/libcbor#340) - This should significantly simplify including libcbor as a dependency/module in Bazel projects, see https://bazel.build/external/migration - Code quality improvements - [Fix compiler pragmas](PJK/libcbor#347) (by [brooksdavis](https://github.com/brooksdavis)) - [Fix code style issues](PJK/libcbor#321) - [Fixed bug in cbor2cjson example](PJK/libcbor#338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds the PROJECT_BINARY_DIR include directly to the cbor target instead of using
include_directories.include_directoriesis limited to the current CMakeLists.txt and anything loaded under it, this makes it impossible to use libcbor as a submodule or via FetchContent since the include path never gets propagated.Checklist