Conversation
- Fix swapped Doxygen comments for definite/indefinite callbacks in callbacks.h (affects generated streaming decoding docs) - Fix incorrect CBOR byte 0xf5 -> 0x5f for indefinite byte string start - Fix incorrect array example: 0x9f -> 0x98 for definite array - Fix missing item argument in cbor_set_uint8 code example - Fix "positive" -> "negative" integer in Type 1 section - Fix CMake minimum version: 2.8 -> 3.5 - Fix swapped cross-references in streaming encoding docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1663 1663
=========================================
Hits 1663 1663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callbacks.h: definite/indefinite labels were reversed for byte strings, arrays, and maps. Sincestreaming_decoding.rstauto-generates from these viadoxygenstruct, the streaming API docs showed wrong descriptions.0xf5(boolean true) ->0x5f(indefinite byte string start)0x9f(indefinite array) described as definite ->0x98(definite array, 1B length)itemargument incbor_set_uint8code example (wouldn't compile)Test plan
🤖 Generated with Claude Code