Skip to content

Remove indentation from the request payload JSON#55

Open
shibayan wants to merge 1 commit intoPKISharp:masterfrom
shibayan:remove-indent
Open

Remove indentation from the request payload JSON#55
shibayan wants to merge 1 commit intoPKISharp:masterfrom
shibayan:remove-indent

Conversation

@shibayan
Copy link

Believe it or not, some ACME implementations return an error if there is indentation in the JSON of the request payload.
win-acme/win-acme#1565

I noticed this problem in the ACME implementation of ZeroSSL.

@ebekker
Copy link
Member

ebekker commented Feb 10, 2021

Hmm, interesting. I assume you confirmed with this change, it is now working with ZeroSSL or similar implementations?

@shibayan
Copy link
Author

shibayan commented Feb 11, 2021

Yes, removing the indentation worked correctly. It's very strange.

I am working on the EAB support now and the following code confirms that it works. Although not included in the PR, ACMESharpCore directly incorporates the version with the indentation removed.
polymind-inc/acmebot#252

Error message:

ProblemType":14,"ProblemTypeRaw":"urn:ietf:params:acme:error:malformed","ProblemDetail":"The JWS Protected Header MUST be present","ProblemStatus":400,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants