Skip to content

📄 feat(docs/joss_paper) joss paper#9

Merged
casenave merged 30 commits intomainfrom
joss_paper
Jun 11, 2025
Merged

📄 feat(docs/joss_paper) joss paper#9
casenave merged 30 commits intomainfrom
joss_paper

Conversation

@casenave
Copy link
Copy Markdown
Member

@casenave casenave commented May 30, 2025 •
edited
Loading

Initial draft PR for joss paper

@casenave casenave self-assigned this May 30, 2025
@casenave casenave marked this pull request as draft May 30, 2025 09:33
@casenave casenave added this to the Joss paper milestone May 30, 2025
@casenave casenave added the documentation Improvements or additions to documentation label May 30, 2025
@casenave casenave changed the title feat(docs/joss_paper) initiate joss paper feat(docs/joss_paper) joss paper May 30, 2025
@casenave casenave requested a review from xroynard May 30, 2025 20:13
@bstaber bstaber changed the title feat(docs/joss_paper) joss paper 📄 feat(docs/joss_paper) joss paper May 31, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@casenave casenave force-pushed the main branch 2 times, most recently from 5351341 to cb91813 Compare June 1, 2025 10:26
@casenave casenave requested a review from TopAgrume June 1, 2025 12:41
@casenave
Copy link
Copy Markdown
Member Author

casenave commented Jun 1, 2025 •
edited
Loading

@xroynard @TopAgrume the paper is compiled by the following GitHub action: https://github.com/PLAID-lib/plaid/actions/workflows/draft-pdf.yml , and the PDF can be downloaded in the artifacts

xroynard
xroynard reviewed Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@xroynard xroynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice ! I’ll add a link to the documentation

xroynard
xroynard reviewed Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@xroynard xroynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice ! I’ll add a link to the documentation

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@casenave
Copy link
Copy Markdown
Member Author

casenave commented Jun 7, 2025

I merged main because ".pre-commit-config.yaml" was expected since I had enabled pre-commmit in my config

@TopAgrume
Copy link
Copy Markdown
Collaborator

TopAgrume commented Jun 7, 2025 •
edited
Loading

I implemented minor grammatical and consistency fixes, enhanced text clarity, and integrated the PLAID architecture image to illustrate the data model. What do you think of the new version?

@TopAgrume TopAgrume requested a review from xroynard June 7, 2025 20:18
@casenave
Copy link
Copy Markdown
Member Author

casenave commented Jun 7, 2025 •
edited
Loading

I implemented minor grammatical and consistency fixes, enhanced text clarity, and integrated the PLAID architecture image to illustrate the data model. What do you think of the new version?

Nice, thanks ! I read again and made minor modifications. Don't forget to sign the CLA here #9 (comment) :-)

TopAgrume
TopAgrume approved these changes Jun 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@TopAgrume TopAgrume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casenave casenave marked this pull request as ready for review June 11, 2025 10:26
@casenave casenave requested a review from a team as a code owner June 11, 2025 10:26
xroynard
xroynard approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@xroynard xroynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casenave casenave merged commit 4a568e5 into main Jun 11, 2025
28 checks passed
@casenave casenave deleted the joss_paper branch June 11, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xroynard xroynard xroynard approved these changes

@TopAgrume TopAgrume TopAgrume approved these changes

Assignees

@casenave casenave

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

Joss paper

Development

Successfully merging this pull request may close these issues.

4 participants

@casenave @CLAassistant @TopAgrume @xroynard