Fix test helpers to restore original database connection#229
Merged
PNixx merged 1 commit intoPNixx:masterfrom Jan 21, 2026
Merged
Fix test helpers to restore original database connection#229PNixx merged 1 commit intoPNixx:masterfrom
PNixx merged 1 commit intoPNixx:masterfrom
Conversation
The minitest and rspec helpers were changing ActiveRecord::Base.connection to ClickHouse without restoring it afterward. This broke multi-database Rails apps where the primary database is PostgreSQL/MySQL. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The minitest and rspec test helpers change
ActiveRecord::Base.connectionto ClickHouse but never restore it afterward. This breaks multi-database Rails apps where the primary database is PostgreSQL/MySQL.Before: After
before_setup(minitest) orbefore(rspec) runs,ActiveRecord::Base.connectionpoints to ClickHouse instead of the app's primary database.After: The original connection is saved before truncating ClickHouse tables and restored afterward.
Changes
lib/clickhouse-activerecord/minitest.rb: Save connection config before iterating ClickHouse configs, restore inensureblocklib/clickhouse-activerecord/rspec.rb: Same fix, plus renamed block variable fromconfigtodb_configto avoid shadowing the outerRSpec.configureblock variableTest plan
ActiveRecord::Base.connectionremains pointed at the primary database after test setup runs🤖 Generated with Claude Code