Fix SchemaDumper incorrectly down casting AggregateFunction types#232
Merged
PNixx merged 1 commit intoPNixx:masterfrom Feb 5, 2026
Merged
Fix SchemaDumper incorrectly down casting AggregateFunction types#232PNixx merged 1 commit intoPNixx:masterfrom
PNixx merged 1 commit intoPNixx:masterfrom
Conversation
jrgarcia
added a commit
to huntresslabs/clickhouse-activerecord
that referenced
this pull request
Mar 4, 2026
… load Upstream PR PNixx#232 fixed the schema dumper to use t.column with raw SQL types for AggregateFunction columns, but the redundant aggregate_function options in the colspec cause add_column_options! to double-wrap the type during schema load (e.g. AggregateFunction(sum, AggregateFunction(sum, Float64))). Add an early-return guard in add_column_options! that skips all type-wrapping options when the SQL type is already a complete (Simple)AggregateFunction definition. Only codec and default are applied. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SchemaDumper was previously downcasting 'SimpleAggregateFunction' and 'AggregateFunction' columns to their base types (e.g. converting 'SimpleAggregateFunction(sum, UInt64)' to ':integer').
This commit modifies the 'table' method to explicitly detect these aggregate types and use 't.column' with the raw SQL definition. This ensures the schema dump preserves the full ClickHouse type wrapper.
Resolves #224