Add Float and Bool subtype support for Map OID#237
Open
Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Open
Add Float and Bool subtype support for Map OID#237Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Conversation
- Add Float32/Float64 subtype handling in Map OID - Add Bool subtype handling in Map OID - Fix Date deserialize crash when value already deserialized - Prevent TimeZoneConverter wrapping Map OID (fixes Hash crash) - Add comprehensive tests for new functionality Fixes serialization issues where Float/Bool values were quoted as strings, causing SYNTAX_ERROR in ClickHouse. Also fixes TypeError on Date re-parsing and 'Hash values are not supported' crash with Map(String, DateTime).
Uladzimiro
force-pushed
the
fix-map-oid-float-bool-support
branch
from
257f3bf to
54aa0ee
Compare
Uladzimiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Map(String, Float32),Map(String, Float64), andMap(String, Bool)columns were not handled by the Map OID type. Float values were serialized with quotes in SQL (causing type errors), and Bool values were not cast correctly.Solution
Add Float and Bool subtype detection in OID::Map#initialize, and handle them in deserialize and serialize.
Tests
Added specs covering: