Fix Map OID deserialize crash for already-parsed Date/DateTime values#239
Open
Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Open
Fix Map OID deserialize crash for already-parsed Date/DateTime values#239Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Uladzimiro wants to merge 1 commit intoPNixx:masterfrom
Conversation
When deserialize was called with an already-parsed DateTime or Time value (e.g. via model.instantiate), it would crash with: TypeError: no implicit conversion of DateTime into String because DateTime.parse was called on an object instead of a string. Root cause: already_deserialized? used bare DateTime/Date which resolved to OID::DateTime/OID::Date (sibling classes in the same module) instead of the standard library types, so the guard never triggered. Fix by using ::DateTime, ::Date, ::Time with explicit root namespace. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deserialize was called with an already-parsed DateTime or Time value (e.g. via model.instantiate), it would crash with:
because DateTime.parse was called on an object instead of a string.