[Refactor] Restructure code and add necessary tests

[Ghass-M]

Summary

• Metrics: Refined per-slice upload metrics and captured worker TaskId to observe parallelism.
• Error handling: Replaced single LastException with aggregated Exceptions list.
• Tests: Added integration tests validating slicing, parallelism, and total uploaded length; updated unit tests accordingly.
• Cleanup: Minor code cleanups and API alignment.

Why

• Bandwidth computation per slice was noisy and unnecessary; external computation can derive rates from bytes and elapsed time.
• Aggregating errors provides richer diagnostics and avoids losing earlier failures.
• Integration coverage ensures slicing behavior and concurrency limits are correct across scenarios.

What changed

• SliceUploadMetric:
  • Added: TaskId.
  • Renamed: DurationMs → ElapsedtimeMs.
  • Removed: BandwidthKbps.
• UploadProgressState:
  • Removed: LastException.
  • Use Exceptions list for error aggregation.
• FileSlicer / FileUploadWorker:
  • Stop setting LastException; append to Exceptions instead.
  • Record TaskId, PartNumber, Bytes, ElapsedtimeMs for each slice.
• FileUploadProcessor:
  • After upload, throw with the last aggregated exception if any exist.
  • Use null-safe count checks.
• Tests:
  • New integration suite Upload_SliceAndParallelism_Tests with a stub IUploadStrategy and IFileTransferApiClient to:
    • Validate one-slice uploads, multi-slice uploads, and two-file uploads.
    • Assert total slice counts, distinct worker TaskId counts, and final uploaded length.
  • Updated UploadProgressState unit tests to use Exceptions (including null, different types, inner exceptions, messages).
  • Minor cleanup in FileUploaderSliceTests (remove unused using).

Breaking changes

• Public model changes:
  • SliceUploadMetric: property rename/removal and new property added.
  • UploadProgressState: LastException removed in favor of Exceptions.
• Impact expected to be internal to the client; downstream consumers must update references accordingly.

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud