feat: improve upload management: FIFO slicing + session-aware adaptiv…

[Ghass-M]

Summary

Introduces a centralized slicing queue to enforce FIFO ordering and bounded concurrency across uploads, and resets adaptive upload parameters on session changes.

Key changes

• New UploadSlicingManager: Adds IUploadSlicingManager and UploadSlicingManager using a Channel<Func<Task>>, FIFO processing, and max concurrency of 2; ignores stale work after session resets.
• Session-aware adaptive reset: AdaptiveUploadController subscribes to ISessionService.SessionObservable and fully resets chunk size, parallelism, and window.
• DI and factory wiring: Registers AdaptiveUploadController and UploadSlicingManager in SingletonsModule; resolves and injects IUploadSlicingManager in FileUploadProcessorFactory.
• Processor integration: FileUploadProcessor enqueues slicing via IUploadSlicingManager instead of starting it directly to ensure ordered execution.
• Tests updated: Adjusts unit tests to use SliceAndEncryptAdaptiveAsync, injects and stubs IUploadSlicingManager, and wires ISessionService mock for the controller.

Rationale

• Problem: Parallel slicers could interleave across files, causing contention and non-deterministic ordering; adaptive state leaked across sessions.
• Solution: Centralize slicing with FIFO + bounded concurrency and reset adaptive state on session change.

Notes

• Backward compatibility: No public API changes; behavior is more predictable under load.
• Configurability: MAX_CONCURRENT_SLICES is set to 2 and can be tuned later.

[paul-fresquet]

Good job 👍 Here are a few comments

[paul-fresquet]

note: the signature might be: Task<UploadProgressState> Enqueue(SharedFileDefinition sharedFileDefinition).

UploadSlicingManager would then instanciate the FileSlicer, the UploadProgressState and return the UploadProgressState.

[sonarqubecloud]

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull Request Overview

This PR introduces a centralized upload slicing queue to enforce FIFO ordering and bounded concurrency across uploads, while also implementing session-aware adaptive parameter resets to improve upload management predictability and consistency.

• Adds UploadSlicingManager to centralize slice processing with FIFO ordering and configurable concurrency limits
• Implements session-aware adaptive upload controller that resets parameters when sessions change
• Refactors upload architecture to use the centralized slicing manager instead of direct slice processing

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
UploadSlicingManager.cs	New centralized manager for FIFO slice processing with bounded concurrency
AdaptiveUploadController.cs	Enhanced with session-aware reset capability and improved downscaling logic
FileUploadProcessor.cs	Refactored to use slicing manager instead of direct FileSlicer dependency
FileSlicer.cs	Added backpressure control to prevent excessive pending slices
FileUploadCoordinator.cs	Changed from bounded to unbounded channel for slice queueing
Multiple test files	Updated tests to accommodate new architecture and dependencies

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}