Skip to content

Conversation

@PPeitsch
Copy link
Owner

@PPeitsch PPeitsch commented Jul 17, 2025

Description

This pull request implements a complete reorganization of the examples/ directory to improve clarity, organization, and scalability.

  • A new, categorized subdirectory structure has been created (dsc/, dilatometry/, kinetic_methods/, data_import/, synthetic_data/).
  • All existing example scripts have been moved from the root examples/ folder into their corresponding new subdirectories.
  • The generic dsc_example.py has been renamed to legacy_dsc_analysis_example.py and its code simplified to serve as a basic, inherited example.

This establishes a clean foundation for adding new, use-case-specific examples in the future.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would break existing functionality)
  • Documentation update
  • Performance improvement
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • CI/CD related changes
  • Test coverage improvement
  • Other (please describe):

Checklist

  • I have followed the project's coding style guidelines
  • I have added tests to cover my changes
  • All new and existing tests pass locally
  • I have updated the documentation accordingly
  • I have added type hints where applicable
  • I have updated the CHANGELOG.md
  • My changes generate no new mypy warnings
  • I have checked code formatting with black (line length 100)
  • I have run isort for import sorting
  • My PR is based on the latest main branch and has no conflicts
  • I have added/updated docstrings in NumPy format

Have you read the Contributing Guidelines?

Fixes #63

- Initializes new subdirectories (`dsc/`, `dilatometry/`, `kinetic_methods/`)
  within the `examples/` directory to establish a scalable structure.
- Adds a `.gitkeep` file to each new directory to ensure they are
  tracked by Git.
- Relocates all existing technique-specific example scripts into their
  corresponding new subdirectories.
@PPeitsch PPeitsch changed the title Feature/add dsc examples refactor(examples): Organize all example scripts into subdirectories Jul 17, 2025
@PPeitsch PPeitsch changed the title refactor(examples): Organize all example scripts into subdirectories ⚡ [Refactor]: Organize all example scripts into subdirectories Jul 17, 2025
- Renames `dsc_example.py` to `legacy_dsc_analysis_example.py` to
  mark it as a basic, inherited script.
- Removes the local `DSCSegmentAnalyzer` class and its redundant logic.
- Simplifies the script to perform a single analysis run on the
  entire dataset, demonstrating the direct use of the library's
  core analysis classes.
- Adds a note at the top of the file clarifying its legacy status.
@PPeitsch PPeitsch force-pushed the feature/add-dsc-examples branch from 29ee159 to a951baf Compare July 17, 2025 23:10
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/pkynetics/__about__.py 100.00% <100.00%> (ø)

Updates the version in `__about__.py` and finalizes the
CHANGELOG.md for the v0.4.2 release. This version includes
robustness improvements to peak detection and a reorganization
of the examples directory.
@PPeitsch PPeitsch merged commit aac4b83 into main Jul 17, 2025
6 checks passed
@PPeitsch PPeitsch deleted the feature/add-dsc-examples branch July 17, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚡ [Feature]: Reorganize examples directory for better clarity and scalability

2 participants